On Tue, Oct 24, 2017 at 8:15 AM, Andrey Okoshkin <a.okosh...@samsung.com> wrote: > Add usage of xmalloc() instead of malloc() in add_to_trie() as xmalloc wraps > and checks memory allocation result. > > Signed-off-by: Andrey Okoshkin <a.okosh...@samsung.com> > --- > Hello, > I'm not sure but it looks like there is a missing check of the malloc result. > memcpy() may crash with SIGSEGV due to the memory allocation failure. > make_trie_node() uses xmalloc() and xcalloc() - so I believe add_to_trie() > also should use it.
Good catch! Thanks for spotting. Trying to find similar occurrences via git grep "= malloc" did not yield other places that need the same fix. Thanks, Stefan
