On Fri, Oct 20, 2017 at 09:23:54AM +0200, Simon Ruderich wrote: > On Thu, Oct 19, 2017 at 04:29:26PM -0400, Jeff King wrote: > > [snip] > > > > --- a/t/t4015-diff-whitespace.sh > > +++ b/t/t4015-diff-whitespace.sh > > @@ -1463,6 +1463,73 @@ test_expect_success 'move detection ignoring > > whitespace changes' ' > > test_cmp expected actual > > ' > > > > +test_expect_failure 'move detection ignoring whitespace at eol' ' > > Shouldn't this be test_expect_success? According to the commit > message "and a new "--ignore-space-at-eol" shows off the breakage > we're fixing.". I didn't actually run the code so I don't know if > the test fails or not.
Thanks, good catch. I had originally added all the tests in a single commit, with the intent of flipping this failure to success. But when I shifted it to just get added here, I accidentally lost that flip. -Peff
