On Sun, Oct 08, 2017 at 02:49:41PM -0400, Derrick Stolee wrote:
> +static inline char get_hex_char_from_oid(const struct object_id *oid,
> + int pos)
> +{
> + static const char hex[] = "0123456789abcdef";
> +
> + if ((pos & 1) == 0)
> + return hex[oid->hash[pos >> 1] >> 4];
> + else
> + return hex[oid->hash[pos >> 1] & 0xf];
> +}
Should "pos" be unsigned? I don't think it matters much in practice (as
long as it's not negative, the results are well defined by the standard,
and this clearly will be between 0 and 40). But it seems funny that we
consistently use unsigned in the rest of the caller and then implicitly
convert to signed here.
-Peff
