On Tue, Oct 03, 2017 at 03:24:41PM +0900, Junio C Hamano wrote: > Jeff King <p...@peff.net> writes: > > > Since that's the only thing I noticed, let's hold off on a reroll for > > the moment to see if there are any more comments (and I won't be > > surprised if Junio just picks it up with the tweak, but we'll see). > > > > Please do make sure that "make test" runs clean before posting (I > > usually run it on each commit to catch any "oops, we broke this and then > > refixed it" in the middle of the series, too). > > OK, I think fixes for both the "flipped" and the "gettext-poison" > breakages are solved locally in my tree already, so I guess this is > ready to be merged to 'next'.
Yes, I think so. Out of curiosity, do you frequently test with GETTEXT_POISON, or did you just guess at a potential problem after reading the tests? Proper use of test_i18ncmp is definitely something we ought to be looking for during review, but I confess it's something I often miss. -Peff
