On Sep 19 2017, Jonathan Nieder <jrnie...@gmail.com> wrote:

> B. #define for_each_string_list_item(item, list) \
>       if (list->items) \
>               for (item = ...; ...; ... )
>
>    This breaks a caller like
>       if (foo)
>               for_each_string_list_item(item, list)
>                       ...
>       else
>               ...
>
>    making it a non-starter.

That can be fixed with a dangling else.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Reply via email to