With the new "if (!submodule) return NULL;" code added in the previous
commit, we don't need to check if submodule is not NULL anymore.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com>
---
 refs.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/refs.c b/refs.c
index a0c5078901..206af61d62 100644
--- a/refs.c
+++ b/refs.c
@@ -1590,13 +1590,11 @@ struct ref_store *get_submodule_ref_store(const char 
*submodule)
        if (!submodule)
                return NULL;
 
-       if (submodule) {
-               len = strlen(submodule);
-               while (len && is_dir_sep(submodule[len - 1]))
-                       len--;
-               if (!len)
-                       return NULL;
-       }
+       len = strlen(submodule);
+       while (len && is_dir_sep(submodule[len - 1]))
+               len--;
+       if (!len)
+               return NULL;
 
        if (submodule[len])
                /* We need to strip off one or more trailing slashes */
-- 
2.11.0.157.gd943d85

Reply via email to