On Mon, Aug 21, 2017 at 9:20 AM, Heiko Voigt <hvo...@hvoigt.net> wrote:
>> So I am a bit curious to learn which part of this change you dislike
>> and why.
>
> I am also curious. Isn't this the same strategy we are using in other
> places?
>
I dislike it because the UX feels crude. When reading the documentation,
it seems to me as if submodule.<name> can be one of the following
(none, checkout, rebase, merge, !<custom-command>)
This is perfect for "submodule-update", whose primary goal is
to update submodules *somehow*. However other commands
git rebase --recurse
git merge --recurse
git checkout --recurse
have a different primary mode of operation (note how their name
is one of the modes from the set above), so it may get confusing
for a user.
'none' and '!<custom-command>' seem like they would be okay
for any of the commands above but then:
git config submodule.<name>.update "!..."
git reset --hard --recurse
git status
# submodule is reported, because "!..." did not 'reset'.
Anyway. That dislike is just a minor gut feeling about the UX/UI
being horrible. I wrote the patch to keep the conversation going,
and if it fixes Lars problem, let's take it for now.
Thanks,
Stefan
