Hello,
On Mon, Aug 21, 2017 at 12:44 PM, Job Snijders <j...@instituut.net> wrote:
> On Mon, Aug 21, 2017 at 12:19:38PM +0200, Giuseppe Bilotta wrote:
> Thank you for your feedback, good point. Please see below:
This looks fine
> ---
>
> Add a 'raw' blob_plain link in history overview
>
> Signed-off-by: Job Snijders <j...@instituut.net>
> ---
> gitweb/gitweb.perl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 9208f42ed..c43bbe331 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5967,6 +5967,9 @@ sub git_history_body {
> $cgi->a({-href => href(action=>"commitdiff",
> hash=>$commit)}, "commitdiff");
>
> if ($ftype eq 'blob') {
> + print " | " .
> + $cgi->a({-href => href(action=>"blob_plain",
> hash_base=>$commit, file_name=>$file_name)}, "raw");
Nitpick: gitweb uses tabs for nested indents, but spaces for
alignment. For this line here, the last tab should be replace with
spaces (to align the $ with the quotes above.)
With that fixed, you can add
Reviewed-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com>
--
Giuseppe "Oblomov" Bilotta
