On Mon, Jul 03, 2017 at 10:49:39PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Mon, Jul 03 2017, brian m. carlson jotted: > > [...] > > 1 file changed, 34 insertions(+), 35 deletions(-) > > [...] > > struct strbuf err = STRBUF_INIT; > > char *refname; > > - unsigned char new_sha1[20]; > > - unsigned char old_sha1[20]; > > + struct object_id new_oid, old_oid; > > [...] > > It's easier to skim these when you leave changes in the number of lines > to separate commits which do more than just rename boilerplate code, > e.g. as in 05/12 where `const char *p` is introduced.
I can do that in the future. I've received feedback in the past that I could coalesce them into one line instead of needing multiple lines, but since I don't have a preference either way, I'm happy to do whatever makes review easier. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
