On Sat, Jun 10, 2017 at 3:40 PM, Ben Peart <peart...@gmail.com> wrote: > Changes from V4 include: ...
I took a look at this patch series except the last patch ([PATCH v5 7/7] fsmonitor: add a performance test) as Junio reviewed it already, and had only a few comments on patches 3/7 and 4/7. I am still not convinced by the discussions following v2 (http://public-inbox.org/git/20170518201333.13088-1-benpe...@microsoft.com/) about using a hook instead of for example a "core.fsmonitorcommand". I think using a hook is not necessary and might not be a good match for later optimizations. For example people might want to use a library or some OS specific system calls to do what the hook does. AEvar previously reported some not so great performance numbers on some big Booking.com boxes with a big monorepo and it seems that using taskset for example to make sure that the hook is run on the same CPU improves these numbers significantly. So avoiding to run a separate process can be important in some cases.
