Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > A follow-up to the existing "type" rule added in an earlier > change. This catches some occurrences that are missed by the previous > rule. > > Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> > ---
Hmph, I wonder if the "type" thing is really needed. Over there, "ptr" is an expression and we can find "free(ptr); ptr = NULL" with the rule in this patch already, no? In any case, I'll queue these patches as-is. Thanks for working on this. > contrib/coccinelle/free.cocci | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/contrib/coccinelle/free.cocci b/contrib/coccinelle/free.cocci > index 35fb992621..f2d97e755b 100644 > --- a/contrib/coccinelle/free.cocci > +++ b/contrib/coccinelle/free.cocci > @@ -17,3 +17,10 @@ T *ptr; > - free(ptr); > - ptr = NULL; > + FREE_AND_NULL(ptr); > + > +@@ > +expression E; > +@@ > +- free(E); > +- E = NULL; > ++ FREE_AND_NULL(E);
