Jonathan Tan <jonathanta...@google.com> writes:
> There is indeed no reason why we need to keep multiple ones separate for
> an extended period of time - my thinking was to let fetch/clone be fast
> by not needing to scan through the entire existing manifest (in order to
> create the new one), letting GC take care of consolidating them ...
Given that fetch/clone already incur network cost and the users
expect to wait for them to finish, I wouldn't have made such a
trade-off.
>> > +int has_missing_blob(const unsigned char *sha1, unsigned long *size)
>> > +{
>>
>> This function that answers "is it expected to be missing?" is
>> confusingly named. Is it missing, or does it exist?
>
> Renamed to in_missing_blob_manifest().
Either that, or "is_known_to_be_missing()", would be OK.
Thanks.
