On Tue, May 23, 2017 at 04:38:07PM +0900, Junio C Hamano wrote: > > First, the unchanged commit message is now (i.e. by using the parsed > > refspecs returned by remote_get()) completely outdated. > > Second, while it properly frees those refspecs, i.e. the array and all > > its string fields, it will now leak the memory pointed by the > > 'refspec' variable. However, why free just that one field of the > > 'struct *remote'? Alas, we don't seem to have a free_remote() > > function... > > I was sifting entries in the draft "What's cooking" report to find > topics to merge to 'next'. I read the series over and as Peff said > in his <20170515224615.f6hnnfngwpier...@sigill.intra.peff.net>, I > think the series overall is good. > > Do you want to update the proposed log message for this one before > the entire thing is merged to 'next'?
I didn't quite say that it was good. I think the overall direction is good, but I had some comments on patch 1. Maybe we want to accept the ugliness there, but I had some suggestions that might make it less bad. -Peff
