Re: [PATCH v2 09/53] builtin/rev-parse: convert to struct object_id

[Jonathan Tan]

On 04/30/2017 07:29 PM, brian m. carlson wrote:
@@ -340,7 +340,7 @@ static int try_parent_shorthands(const char *arg)
        }
        if (include_rev)
-               show_rev(NORMAL, sha1, arg);
+               show_rev(NORMAL, &oid, arg);
        for (parents = commit->parents, parent_number = 1;
             parents;
             parents = parents->next, parent_number++) {
@@ -352,7 +352,7 @@ static int try_parent_shorthands(const char *arg)
                if (symbolic)
                        name = xstrfmt("%s^%d", arg, parent_number);
                show_rev(include_parents ? NORMAL : REVERSED,
-                        parents->item->object.oid.hash, name);
+                       & parents->item->object.oid, name);

No space after ampersand.

Up to (and including) this patch, looks good. I didn't notice any 
changes other than introductions of parse_oid_hex() and mechanical changes.