On Mon, Apr 17, 2017 at 9:12 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Two questions. > > - Is it better to add a brand new test script than adding new tests > to existing scripts that test "git rebase"? Since this is a completely (in some sense) new feature, I felt it was appropriate to put all --signoff-related tests in their own file. So, if the need arises to put more tests concerning the interaction of signoff with other stuff, this new test file can be extended. > - How does this interact with "git rebase -i" and other modes of > operation? A better question would maybe be how do we want this to interact? For example, with -i: do we want -i --signoff to just sign off everything? Or do we want a new -i command (o, signoff) to signoff only individual commits on request? When preserving merges, do we want to sign-off merge-commits too? I'm not entirely sure what the best policy would be. -- Giuseppe "Oblomov" Bilotta
