On Thu, Apr 06, 2017 at 09:26:15AM -0400, Jeff Hostetler wrote:

> > > +export depth
> > > +export width
> > > +export files
> > 
> > Why are these exported?  test_expect_success code (unlike test_per
> > code) runs in the same shell as outside, so it doesn't seem necessary.
> 
> I'm still trying to grok all of the shell wizardry hidden
> in the test_* functions, so some may be novice mistakes here.
> However, I couldn't get some of the steps to run in an earlier
> draft of it without them.  But I copied this from p0004-read-tree
> that I posted in an earlier patch and this version is much simpler
> so they may not be necessary here.  I'll double check.

It's a subtle but annoying difference between the regular tests and the
perf tests. test_perf() runs in a subshell because of the way the timing
is implemented. There are a few pointers in t/perf/README regarding
this.

-Peff

Reply via email to