On Thu, Mar 30, 2017 at 11:03:51AM -0700, Junio C Hamano wrote: > With the "--decorate=auto" option becoming the default for "git > log", "git tbdiff" will be broken. > > The configuration variable has been already there, so in that sense > this is not a new breakage (tbdiff wouldn't have worked well for > those with configured default). A fix is trivial (attached). > > I suspect that Alex's change may uncover similar breakages in > people's scripts. Perhaps the topic should be cooked a bit longer > than other topics on 'next'?
I'm confused. I thought "auto" would kick in only when we are outputting to a terminal. Or is the problem that the "is it a terminal" check is fooled by $GIT_PAGER_IN_USE, because you are running "git -p tbdiff"? If so, this is the symptom of a more general problem, which is that a script outputting to a pager will have confused sub-processes, who do not know if their pipe is the pager one or not. Perhaps it is time to resurrect my patch from: http://public-inbox.org/git/20150810052353.gb15...@sigill.intra.peff.net/ I think it would need a Windows-specific variant, but the general idea is sound. -Peff PS I've been running git-tbdiff occasionally for years with log.decorate set to "true". I wonder why I haven't noticed any problems.
