On Tue, Mar 14, 2017 at 1:23 AM, Brandon Williams <bmw...@google.com> wrote:
> v3 fixes some nits in style in the test script (using <<-\EOF instead of 
> <<-EOF)
> as well as fixing a few other minor things reported by Junio and Jonathan.

I'm slowly digging through the pile of mails in the past weeks... I
know this has landed on 'master' (thanks!). Just wanted to check
something.

The series updated match_pathspec(), but that's only one of two
pathspec filtering functions. The other is tree_entry_interesting()
(e.g. for "git grep <tree>"). Do you have plans to support :(attr)
there too? "No" is a perfectly fine answer (and it will end up in my
forever growing backlog).

The thing about tree_entry_interesting() is, we would want to stop
traversing subtrees as soon as possible. Naively implemented, we would
need to traverse all subtrees so we can call match_attrs(). That's not
great. Oii I'm rambling.. I don't know yet how to implement this thing
efficiently.
-- 
Duy

Reply via email to