Brandon Williams <bmw...@google.com> writes: > + if git config --get submodule.active >/dev/null > + then > + # If the submodule being adding isn't already covered by the > + # current configured pathspec, set the submodule's active flag > + if ! git submodule--helper is-active "$sm_path" > + then > + git config --add submodule."$sm_name".active "true" > + fi > + else > + git config --add submodule."$sm_name".active "true" > + fi
Why "--add"? That's a way to add new entry for multi-valued configuration, but you do not care if the old value (if existed) were false or true---you want to replace it to true here, no?
