On Wed, Nov 07, 2012 at 06:35:15PM -0500, Paul Fox wrote: > the user's editor likely catches SIGINT (ctrl-C). but if the user > spawns a command from the editor and uses ctrl-C to kill that command, > the SIGINT will likely also kill git itself. (depending on the > editor, this can leave the terminal in an unusable state.) > > Signed-off-by: Paul Fox <p...@foxharp.boston.ma.us>
Thanks, I think this makes sense. > krzysztof wrote: > ... > > editor.c: In function 'launch_editor': > > editor.c:42:3: warning: implicit declaration of function 'sigchain_push' > [-Wimplicit-function-declaration] > > editor.c:44:3: warning: implicit declaration of function 'sigchain_pop' > [-Wimplicit-function-declaration] > > sigh. i had that initially, lost the patch, and then recreated > without it. but i'm surprised my build (i did rebuild! :-) doesn't > emit those errors. in any case, here's the fixed patch. gcc will not warn about implicit declarations by default; try compiling with "-Wall". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
