On 02/28/2017 05:28 AM, Jeff King wrote:
Right, your patch makes sense. A real HTTP error should take precedence
over the url-update trickery.
Acked-by: Jeff King <p...@peff.net>
Thanks!
Running your included test, we get:
fatal: unable to access 'http://127.0.0.1:5550/redir-to/502/': The
requested URL returned error: 502
but the error really happened in the intermediate step. I wonder if we
should show the effective_url in that case, as it's more likely to
pinpoint the problem. OTOH, we do not mention the intermediate redirect
at all, so they might be confused about where that URL came from. If you
really want to debug HTTP confusion, you should use GIT_TRACE_CURL.
Yeah, if we mention the effective_url, I think that there would need to
be a lot more explaining to be done (e.g. why does my URL have
"info/refs?service=git-upload-pack" tacked on at the end). It might be
better to just recommend GIT_TRACE_CURL.
