On Fri, Feb 17, 2017 at 06:40:28PM -0500, Kyle Meyer wrote: > > For reference, the two things I notice are: > > > > - we prefer test_path_is_missing to "! test -f" these days. > > > > - we don't redirect the output of grep (it's handled already in > > non-verbose mode, and in verbose mode we try to be...verbose). > > Would moving cleanup like "rm -f .git/$m" within the test's body using > test_when_finished also be preferred?
Yeah, that too. I forgot to mention it. -Peff
