On Wed, Feb 15, 2017 at 4:38 PM, Stefan Beller <sbel...@google.com> wrote: > + if (is_active_submodule_with_strategy(ce, SM_UPDATE_UNSPECIFIED))
Here, and in other cases where we use is_active_submodule_with_strategy(), why do we only ever check SM_UPDATE_UNSPECIFIED? It seems really weird that we're only going to check submodules who's strategy is unspecified, when that defaults to checkout if I recall correctly? Shouldn't we check both? This applies to pretty much everywhere that you call this function that I noticed, which is why I removed the context. Thanks, Jake
