On Wed, Feb 15, 2017 at 10:22 AM, Junio C Hamano <gits...@pobox.com> wrote: > Stefan Beller <sbel...@google.com> writes: > >> In a later patch we'll use connect_work_tree_and_git_dir when the >> directory for the gitlink file doesn't exist yet. Safely create >> the directory first. >> >> Signed-off-by: Stefan Beller <sbel...@google.com> > > Among the existing two callers, the "absorb" logic in submodule.c > has safe-create-leading-directory (SCLD) immediately before the call > to this function, which can now be lost with this change. The other > one in cmd_mv() has the target directory as the result of moving the > original directory, and I do not think there is any corresponding > call that can be lost from there after this change, but it is not an > error to call SCLD on a path that already exists, so all is OK. > > Is it sensible to let the code continue with just an fprintf() (not > even warning() or error()) when SCLD fails?
I'll move the code from the absorbing here (i.e. lose the SCLD lines there) and make it a die(_(..)) instead of fprintf here. Thanks, Stefan
