Hi Mike, On Thu, 9 Feb 2017, Mike Rappazzo wrote:
> On Thu, Feb 9, 2017 at 4:48 AM, Duy Nguyen <pclo...@gmail.com> wrote: > > > Relevant thread in the past [1] which fixes both --git-path and > > --git-common-dir. I think the author dropped it somehow (or forgot > > about it, I know I did). Sorry can't comment on that thread, or this > > patch, yet. > > I didn't exactly forget it (I have it sitting in a branch), I wasn't > sure what else was needed (from a v5 I guess), so it has stagnated. > > There was also another patch [1] at the time done by SZEDER Gábor trying > to speed up the completion scripts by adding `git rev-parse > --absolute-git-dir` option to deal with this case as well. > > > [1] > > http://public-inbox.org/git/1464261556-89722-1-git-send-email-rappa...@gmail.com/ > > [1] http://public-inbox.org/git/20170203024829.8071-16-szeder....@gmail.com/ Ah, so I was not the only person reporting this bug, but I am seemingly having as much luck getting a fix in. I had a quick look at your v4: http://public-inbox.org/git/1464261556-89722-3-git-send-email-rappa...@gmail.com/ It seems you replaced the git_path() by a combination of git_dir() and relative_path(), but that would break the use case where git_path() handles certain arguments specially, e.g. "objects" which knows that the .git/objects/ path can be overridden via the environment. I tried very hard to keep that working in my patch, essentially by emulating what git_path() does already when being called in a worktree's subdirectory: make the path absolute. Ciao, Johannes
