On Thu, Jan 26, 2017 at 07:18:41PM +0000, Eric Wong wrote:
> > Eric Wong <e...@80x24.org> writes:
> Junio C Hamano <gits...@pobox.com> wrote:
> > + "<citerefentry>\n"
> > + "<refentrytitle>#{target}</refentrytitle>"
> > + "<manvolnum>#{attrs[1]}</manvolnum>\n"
> > + "</citerefentry>\n"
> > end
>
> You need the '\' at the end of those strings, it's not like C
> since Ruby doesn't require semi-colons to terminate lines.
> In other words, that should be:
>
> "<citerefentry>\n" \
> "<refentrytitle>#{target}</refentrytitle>" \
> "<manvolnum>#{attrs[1]}</manvolnum>\n" \
> "</citerefentry>\n"
> This change is fine with me. For the record, I don't have a strong opinion one way or the other. Since this code is related to Asciidoctor and Git has no existing Ruby style standards, I picked the Asciidoctor house style, which uses multi-line %(). We could pick [0] as an option, or just argue it out when someone cares, like here. [0] https://github.com/bbatsov/ruby-style-guide -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
