Johannes Sixt <j...@kdbg.org> writes: >>> - dup2(new_fd, fd); >>> if (console == handle) >>> console = duplicate; >>> - handle = INVALID_HANDLE_VALUE; >>> + dup2(new_fd, fd); >>> >>> /* Close the temp fd. This explicitly closes "new_handle" >>> * (because it has been associated with it). >>> > > Looks good and obviously correct (FLW). I can offer a > > Reviewed-by: Johannes Sixt <j...@kdbg.org> > > but it will take a day or two until I can test the patch.
I think a Reviewed-by is good enough, as the original <2ce6060b891f8313cc63a95a9cba9064b7f82eb8.1482448531.git.johannes.schinde...@gmx.de> already has "Tested-by" to indicate that as a whole this have been tested. The "follow-up" we are commenting on was made out of that original to incrementally update the older version that was queued and merged to 'master' 3 weeks ago. Thanks.
