Junio C Hamano <gits...@pobox.com> writes: > Jeff King <p...@peff.net> writes: > >> On Thu, Dec 15, 2016 at 08:37:28PM -0500, Jeff King wrote: >> >>> But if this case really is just "if (from_stdin)" that's quite easy, >>> too. >> >> So here is that patch (with some associated refactoring and cleanups). >> This is conceptually independent of >> jk/no-looking-at-dotgit-outside-repo-final, >> though it should be fine to merge with that topic. The BUG will actually >> pass the new test, because it calls die, too. I wonder if we should die >> with a unique error code on BUGs, and catch them in test_must_fail >> similar to the way we catch signal death. >> >> [1/3]: t5000: extract nongit function to test-lib-functions.sh >> [2/3]: index-pack: complain when --stdin is used outside of a repo >> [3/3]: t: use nongit() function where applicable > > I think 2/3 is a good change to ensure we get a reasonable error for > "index-pack --stdin", and 3/3 is a very good cleanup. Both of them > of course are enabled by 1/3. > > We still fail "nongit git index-pack tmp.pack" with a BUG: though.
Wait. This only happens with a stalled-and-to-be-discarded topic on 'pu'. Please don't waste time digging it (yet).
