On Tue, Nov 1, 2016 at 8:28 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> This function will be used in a following commit to get the expiration >> time of the shared index files from the config, and it is generic >> enough to be put in "config.c". > > Is it generic enough that a helper that sounds as if it can get any > date string dies if it is given a future date? I somehow doubt it. > > At the minimum, it must be made clear that there is an artificial > limitation that the current set of callers find useful in cache.h as > a one-liner comment next to the added declaration. Then people with > the same need (i.e. they want to reject future timestamps) can > decide to use it, while others would stay away from it. > > If you can come up with a better word to use to encode that > artificial limitation in its name, renaming it is even better.
Ok it will appear like this in cache.h: /* This dies if the configured or default date is in the future */ extern int git_config_get_expire_date_string(const char *key, const char **output); Thanks, Christian.
