On 14.11.16 10:11, Lars Schneider wrote: > >> On 13 Nov 2016, at 02:13, Junio C Hamano <gits...@pobox.com> wrote: >> >> Johannes Schindelin <johannes.schinde...@gmx.de> writes: >> >>>> Thanks. Dscho, does this fix both of these issues to you? >>> >>> Apparently it does because the CI jobs for `master` and for `next` pass. >> >> OK, thanks for a quick confirmation. >> >>> The one for `pu` still times out, of course. >> >> Earlier you said 'pu' did even not build, but do we know where this >> "still times out" comes from? As long as I don't merge anything >> prematurely, which I need to be careful about, it shouldn't impact >> the upcoming release, but we'd need to figure it out before moving >> things forward post release. > > What is the goal for 'pu'? >
> (1) Builds clean on all platforms + passes all tests Yes > (2) Builds clean on all platforms Yes > (3) Builds clean on Linux Yes > (4) Just makes new topics easily available to a broader audience Yes > > My understanding was always (4) but the discussion above sounds > more like (1) or (2)? All commits should work on all platforms - in the ideal world there is no problem. >From time to time things sneak in, which are not portable. (in the sense that not all "supported" compile/run tests without breakages) And if everybody reports breakages and problems found on the pu branch, there is a good chance that they don't reach next or master. Does this make sense ? > > -- > > Git 'pu' does not compile on macOS right now: > builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used > uninitialized > whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > ... > > More info here: > https://api.travis-ci.org/jobs/175417712/log.txt?deansi=true > > -- > > Cheers, > Lars >
