On Tue, Nov 1, 2016 at 8:05 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Duy Nguyen <pclo...@gmail.com> writes:
>
>>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>>> index b75ea03..a14dbf2 100644
>>> --- a/builtin/update-index.c
>>> +++ b/builtin/update-index.c
>>> @@ -1098,12 +1098,21 @@ int cmd_update_index(int argc, const char **argv,
>>> const char *prefix)
>>> }
>>>
>>> if (split_index > 0) {
>>> + if (git_config_get_split_index() == 0)
>>> + warning("core.splitIndex is set to false; "
>>> + "remove or change it, if you really want to
>>> "
>>> + "enable split index");
>>
>> Wrap this string and the one below with _() so they can be translated.
>
> True.
>
> I further wonder if a natural reaction from users after seeing this
> message is "I do want to--what else would I use that option to run
> you for? Just do as you are told, instead of telling me what to
> do!". Is this warning really a good idea, or shouldn't these places
> be setting the configuration?
In 435ec090ec (config: add core.untrackedCache, 2016-01-27) we decided
to just use warning() after discussing if we should instead set the
configuration.
