On Thu, Oct 20, 2016 at 12:57:01PM -0400, Santiago Torres wrote: > > I think you'd really just squash the various bits of this into your > > series at the right spots, though I don't mind it on top, either. > > > > The big question is to what degree we should care about the verify-tag > > case. I don't think it's any worse off with this change than it is with > > your series (its "kind" becomes "OTHER", but I don't think that is > > actually used for display at all; the name remains the same). I'd be OK > > with leaving it like this, as a known bug, until get_sha1_with_context() > > learns to tell us about the ref. It's an unhandled corner case in a > > brand-new feature, not a regression in an existing one. > > I see now, I think I can sprinkle some of these changes on 2/7 then. The > rest should be doing 4/7 and 5/7. Does this sound ok?
Yep, that sounds about right. -Peff
