Dennis Kaarsemaker <den...@kaarsemaker.net> writes:

> +     touch expect &&
> +     printf "\0" > expect &&

What's the point of that "touch", especially if you are going to
overwrite it immediately after?

> +     git rev-list --header --max-count=1 HEAD | tail -n1 >actual &&

As "tail" is a tool for text files, it is likely unportable to use
"tail -n1" to grab the "last incomplete line that happens to contain
a single NUL".

> +     test_cmp_bin expect actual
> +'

Reply via email to