On 10/10/2016 04:57 PM, Jeff King wrote:
[+cc authors of b1c8a11, which regressed this case; I'll quote liberally
to give context]
On Mon, Oct 10, 2016 at 05:48:56PM -0400, Jeff King wrote:
I can't reproduce the problem with this simple setup:
git init
echo content >file && git add file
git commit -F- <<-\EOF
the subject
the body
Cc: Stable <sta...@vger.kernel.org> [4.8+]
EOF
If I then run:
git send-email -1 --to=p...@peff.net --dry-run
I get:
/tmp/MH8SfHOjCv/0001-the-subject.patch
(mbox) Adding cc: Jeff King <p...@peff.net> from line 'From: Jeff King
<p...@peff.net>'
(body) Adding cc: Stable <sta...@vger.kernel.org> [4.8+] from line 'Cc:
Stable <sta...@vger.kernel.org> [4.8+]'
Dry-OK. Log says:
Sendmail: /usr/sbin/sendmail -i p...@peff.net sta...@vger.kernel.org
From: Jeff King <p...@peff.net>
To: p...@peff.net
Cc: "Stable [4.8+]" <sta...@vger.kernel.org>
Subject: [PATCH] the subject
Date: Mon, 10 Oct 2016 17:44:25 -0400
Message-Id: <20161010214425.9761-1-p...@peff.net>
X-Mailer: git-send-email 2.10.1.527.g93d4615
Result: OK
So it looks like it parsed the address, and shifted the "4.8+" bit into
the name, which seems reasonable. Does my example behave differently on
your system? If not, can you see what's different between your
real-world case and the example?
It might also be related to which perl modules are available. We'll use
Mail::Address if you have it, but some fallback routines if you don't.
They may behave differently.
Alternatively, if this used to work, you might try bisecting it.
Ah, it is Mail::Address. It gets this case right, but if I uninstall it,
then the cc becomes:
Cc: Stable <sta...@vger.kernel.org[4.8+]>
that you saw, which is broken. Older versions of git, even without
Mail::Address, got this right. The breakage bisects to b1c8a11
(send-email: allow multiple emails using --cc, --to and --bcc,
2015-06-30) from v2.6.0, but I didn't dig deeper into the cause.
I did not have Mail::Address installed, but adding it did not help.
I solved my immediate problem by moving the [4.8+] between Stable and the
starting <. The result is spaced funny, but at least the info is there.
Larry
