Kevin Wern <kevin.m.w...@gmail.com> writes: > On Fri, Sep 16, 2016 at 04:07:00PM -0700, Junio C Hamano wrote: >> Kevin Wern <kevin.m.w...@gmail.com> writes: >> >> > Add option RUN_COMMAND_NO_STDOUT, which sets no_stdout on a child >> > process. >> > >> > This will be used by git clone when calling index-pack on a downloaded >> > packfile. >> >> If it is just one caller, would't it make more sense for that caller >> set no_stdout explicitly itself? > > I based the calling code in do_index_pack on dissociate_from_references, which > uses run_command_v_opt, so it never occured to me to do that. I thought it was > just good, uniform style and encapsulation. Like how transport's methods and > internals aren't really intended to be changed or accessed--unless it's > through > the APIs we create. > > However, I don't feel very strongly about this, so I'm okay with this change.
I am neutral and with no opinion. I may have offered a solution to a problem that did not exist. I just got an impression that you were apologetic for having to add this option that is otherwise useless and tried to suggest a simpler solution that does not involve such an addition.
