On Mon, 2016-09-05 at 05:53 +0200, Michael Haggerty wrote: > On 09/04/2016 10:40 PM, David Turner wrote: > > On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote: > > > >> +/* A linked list of ref_stores for submodules: */ > >> +static struct ref_store *submodule_ref_stores; > > > > I don't like the per-submodule stores being in a linked list, which > > requires a linear search. Stefan has, I think, been doing a bunch of > > work to scale git to support on the order of thousands of submodules, > > which this potentially breaks. What about a hashmap? > > I agree it's not ideal, but this linked list is not new. Before this > patch the same code was in `files-backend.c`, and before patch [03/38] > essentially the same linked list was stored as `submodule_ref_caches`. > So this is not a regression, and I'd rather not address it in this patch > series.
Fair enough!
