On Thu, Aug 18, 2016 at 12:00 AM, David Aguilar <dav...@gmail.com> wrote: >> +void show_submodule_summary(FILE *f, const char *path, >> + const char *line_prefix, >> + unsigned char one[20], unsigned char two[20], >> + unsigned dirty_submodule, const char *meta, >> + const char *del, const char *add, const char *reset) > > > ... and here too. > > There's an ongoing effort to replace unsigned char sha1[20] > with struct object_id. It might make sense to pass "one" and > "two" as "unsigned char*" instead of hard-coding the SHA1-length > here. Alternatively, we could pass in the struct object_id* > instead. > > The [20] in the show_submodule_header() function above is > pre-existing and not added by this patch, but that function's > signature is touched by this patch so it might make sense to > tidy that up while we're in here, possibly as a separate patch. > --
I'll add a patch to the series that does this inbetween these commits. Thanks, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
