> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Saturday, September 08, 2012 9:04 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] daemon: restore getpeername(0,...) use > > "Joachim Schmitz" <j...@schmitz-digital.de> writes: > > >> + setenv("REMOTE_PORT", portbuf, true); > > > > setenv() is not a function available on all plattfomrs. > > Please do some homework before adding irrelevant noise. At the > minimum, run "git grep" to see if we already use it in other places, > and investigate why we can use it safely across platforms we already > support.
Hmm, guess I missed the indirect inclusion of git-compat-util.h And didn't know about 'git grep', so thanks for the hint Will look closer next time ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
