On Fri, Sep 7, 2012 at 12:34 AM, Junio C Hamano <gits...@pobox.com> wrote: > Modulo that I suspect you could get rid of offset_1st_component() > altogether and has_dos_drive_prefix() return the length of the "d:" > or "//d" part (which needs to be copied literally regardless of the > "normalization"), what you suggest feels like the right approach. > Why do you need the "keep_root" parameter and do things differently > depending on the setting by the way?
That's how offset_1st_component() originally works, root slash if present is counted. > Wouldn't "skip the root level > when computing the offset of the first path component" something the > caller can easily decide to do or not to do, and wouldn't it make > the semantics of the function cleaner and simpler by making it do > only one thing and one thing well? Yeah. I'll have a closer look later and see if we can simplify the function. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
