On 08/05, Junio C Hamano wrote:
> Thomas Gummerer <t.gumme...@gmail.com> writes:
> 
> > +   stat_crc = crc32(stat_crc, (Bytef*)&stat, 4);
> > +   stat = htonl(ce->ce_ino);
> > +   stat_crc = crc32(stat_crc, (Bytef*)&stat, 4);
> > +   stat = htonl(ce->ce_size);
> > +   stat_crc = crc32(stat_crc, (Bytef*)&stat, 4);
> > +   stat = htonl(ce->ce_dev);
> > +   stat_crc = crc32(stat_crc, (Bytef*)&stat, 4);
> > +   stat = htonl(ce->ce_uid);
> > +   stat_crc = crc32(stat_crc, (Bytef*)&stat, 4);
> > +   stat = htonl(ce->ce_gid);
> > +   stat_crc = crc32(stat_crc, (Bytef*)&stat, 4);
> > +   return stat_crc;
> 
> What are these (Bytef *) casts are about?  We do not use it in any
> of our existing calls to crc32().

>From a quick look over the existing calls, their argument is
always either a void* or a char* pointer.  Using pointers other
than those two or Bytef* gives compiler warnings.  I can cast
to either void* or char* if that's preferred.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to