The nested quoting is not needed in this cases, thus the previous
version did work just fine. Nevertheless the usage is misleading,
so just achieve nested quoting by using double quotes instead. Lower
the probability of breakage in the future and make the code easier
to read.

NOTE: Just dropping the single quotes around the sed arguments would
      have also been possible.

Signed-off-by: Alexander Strasser <eclip...@gmx.net>
Signed-off-by: Junio C Hamano <gits...@pobox.com>
---
 t/t4012-diff-binary.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index 3c54269..60c2f6c 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -64,7 +64,7 @@ test_expect_success 'apply --numstat understands diff 
--binary format' '
 # apply needs to be able to skip the binary material correctly
 # in order to report the line number of a corrupt patch.
 test_expect_success 'apply detecting corrupt patch correctly' '
-        git diff | sed -e 's/-CIT/xCIT/' >broken &&
+        git diff | sed -e "s/-CIT/xCIT/" >broken &&
         if git apply --stat --summary broken 2>detected
         then
                echo unhappy - should have detected an error
@@ -79,7 +79,7 @@ test_expect_success 'apply detecting corrupt patch correctly' 
'
 '
 
 test_expect_success 'apply detecting corrupt patch correctly' '
-        git diff --binary | sed -e 's/-CIT/xCIT/' >broken &&
+        git diff --binary | sed -e "s/-CIT/xCIT/" >broken &&
         if git apply --stat --summary broken 2>detected
         then
                echo unhappy - should have detected an error
-- 
1.7.10.2.552.gaa3bb87
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to