Petr Baudis <[EMAIL PROTECTED]> writes:
> Dear diary, on Fri, Jul 29, 2005 at 11:55:52AM CEST, I got a letter
> where Catalin Marinas <[EMAIL PROTECTED]> told me that...
>> Petr Baudis <[EMAIL PROTECTED]> wrote:
>> > The committer field generally identifies the committer "physically", and
>> > isn't usually overriden. You'll find <[EMAIL PROTECTED]> in my
>> > committer field, e.g.
>>
>> I thought GIT_COMMITTER_{NAME,EMAIL} were added to be able to override
>> the defaults like [EMAIL PROTECTED]
>
> Yes, but IIRC only for rather special cases like recommitting older
> commits, importing from other VCSes, etc.
My recollection coincides with Catalin. Special case is when
you set it to somebody else, "logically" different from you, as
you say. Fixing GECOS fields and mailhost settings as Catalin
says is another.
Setting it to something "physically" different but still the
same you, for example using your work e-mail address when you
are on your home machine, is not special case at all, but is
also a valid use. However when you start to do that, it may
become unusable as a valid e-mail address you can use for From:
and/or Sender: fields.
>> The latest StGIT snapshot uses, by default, the committer's details
>> for the From: line when sending patches by e-mail, assuming that this
>> is a valid e-mail address. One can define his own e-mail template and
>> use a different From: line but I thought it would be simpler to
>> provide some defaults based on this.
>
> Why don't you rather use the GIT_AUTHOR_* variables?
I tend to agree. When forwarding somebody else's commit as a
patch, you would want to name that author on From: line and make
yourself Sender:. Of course, in that case Sender: should be a
valid e-mail address for the originating machine; otherwise
bogus-mail-relay prevention would block your e-mail. In that
sense, using COMMITTER to identify you "physically" (meaning:
tied to your identity with that particular machine) would work
better.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
