Bryan Larsen <[EMAIL PROTECTED]> writes:

> Update the git Makefile to put the results of config.sh into the scripts.  
> config.sh searches for gnu utilities cp, stat, date and xargs.
>
> Signed-off-by: Bryan Larsen <[EMAIL PROTECTED]>

> +install: $(PROG) $(SCRIPTS) config
>       $(INSTALL) -m755 -d $(dest)$(bin)
>       $(INSTALL) $(PROG) $(SCRIPTS) $(dest)$(bin)
> +     . ./config ; \
> +     cd $(dest)$(bin) ; \
> +     for file in $(SCRIPTS); do \
> +             sed -e "s/DATE\=date/DATE=$${DATE}/" -e "s/CP\=cp/CP=$${CP}/" 
> -e "s/XARGS\=xargs/XARGS=$${XARGS}/" -e "s/STAT\=stat/STAT=$${STAT}/" $$file 
> > $$file.new; \
> +             cat $$file.new > $$file; rm $$file.new; \
> +     done

I am not yet convinced "one variable per GNU program" is the
right way to do (I do agree it is a problem and I appreciate
your trying to solving it; an obvious alternative cop-out would
be to fix this in the user's environment, but there might be a
saner solution).  Assuming that this is the way to go, wouldn't
it be saner if this sed munging is done in only one place, say
git-sh-setup-script, and have everybody include that?  If we
want to have some scripts usable not at the top-level GIT
directory, then git-sh-setup-script may not be a good place; in
which case introduce git-sh-compat-script and have everybody
include _that_ instead?


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to