On Sun, 17 Apr 2005, Jan-Benedict Glaw wrote:
> On Sat, 2005-04-16 18:03:51 -0400, Daniel Barkalow <[EMAIL PROTECTED]>
> wrote in message <[EMAIL PROTECTED]>:
> > --- /dev/null (tree:ed4f6e454b40650b904ab72048b2f93a068dccc3)
> > +++ a65375b46154c90e7499b7e76998d430cd9cd29d/http-get.c (mode:100644
> > sha1:6a36cfa079519a7a3ad5b1618be8711c5127b531)
>
> > + local = open(filename, O_WRONLY | O_CREAT | O_EXCL, 0666);
>
> 0666 is a bit too lazy. I'd suggest 0664 or 0644.
Actually, 0444 would make most sense, since these shouldn't get modified
at all. But umask is applied to them anyway, so 0664 or 0644 (or 0660 or
0600) is up to the local system policy. This just matches
write_sha1_buffer().
-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
