On Fri, 15 Apr 2005, Morten Welinder wrote: > > This write will failing sooner or later when someone's disk fills up. > That'll leave someone with a truncated file.
Yes. On the other hand, we could try to do this even better, ie make the classic write loop that handles EAGAIN. No POSIX filesystem is supposed to return EAGAIN, but there are tons of "POSIX enough" filesystems. Notably NFS when mounted with "intr" (which some people think is wrong, but it tends to be better than the alternatives if your network is flaky enough). But yes, even just a "write failed" is good enough, except you should also make sure that you remove the corrupt file. Sure, fsck will catch it, but if you don't do an fsck, somebody else might decide not to write the file out simply because "it's already there". (This is also why we should write to a temp-file and then do an atomic "rename()"). Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html