Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43287?usp=email )
Change subject: saip BatchPersonalization: call rebuild_mandatory_services() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I don't see how we'd ever need to rebuild the mandatory service list on a > _per profile_ basis. […] The process is: - load the template - modify it - then set up the 5G SUCI and other flags according to what is found in the PES. That means i have to call the function after each profile has all information in the PES -- in the unchanged template, the 5G SUCI calc info is not set up yet, so we cannot determine which flags it needs. Not sure how else one would do this. This function is fast because it just sets a couple of flags, right? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f Gerrit-Change-Number: 43287 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2026 22:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
