Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email )
Change subject: Update README.md related to the current command line parameters ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File README.md: https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/6c0b2589_0e7c1ee4?usp=email : PS2, Line 4: element in the 3GPP IoT eSIM system as described in SGP.31 and SGP.32. It interfaces between the eUICC on one side, oops! There is a trailing white space that was already there before... https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/3026d2b4_48729ad7?usp=email : PS2, Line 95: * `add-initial-eim <PATH>` specifies the path to an initial eIM configuration file. I would move this line to the bottom since we usually pass the operations at the end of the command-line. And it looks more consistent. https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/3db718a6_91f023a4?usp=email : PS2, Line 104: During the first run, onomondo-ipa will create an `nvstate.bin` file in its working directory. again A whitsepace that has been overlooked. We should remove it with this patch. https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/b844be2a_92b7404f?usp=email : PS2, Line 121: the eidValue from the eUICC and use it to query the eIM for eIM packages. In case no eIM package is available (error I would change "it will read the eUICC configuration" To "it will read the eIM configuration data" -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485 Gerrit-Change-Number: 43403 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 13:20:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
