Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email )
Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ...................................................................... Patch Set 2: -Code-Review (1 comment) File src/xua_msg.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389/comment/54c527f8_4b59e16e?usp=email : PS2, Line 549: return 0; This is unexpected to me. I would expect: * Ensure beforehand that msg_class is in the proper range to be used with dialect->class and log an error + reject the message if not. * OSMO_ASSERT(xmc) here. Otherwise I guess a message could be crafted to bypass xua_dialect_check_all_ies by setting msg_class to a value that results in !xmc being true. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9df00f9b10f7341171912cf32e8ba57344ae8b4a Gerrit-Change-Number: 43389 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
