Attention is currently required from: lynxis lazus, osmith, pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email )

Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on 
re-Attach
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS3:
> @[email protected] shouldn't this be covered by  […]
No, `process_ms_ctx_status()` does not apply here. It's wired up only for RA 
Update Request and Service Request, where it reads the 
`GSM48_IE_GMM_PDP_CTX_STATUS` IE and checks NSAPIs the MS reports as inactive 
against what the SGSN still holds. GMM Attach Request does not have that IE at 
all.


File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/42594/comment/b9e075c7_11a39478?usp=email
 :
PS3, Line 1348:                                 sgsn_pdp_ctx_terminate(pdp);
> calling  […]
Acknowledged. See https://gerrit.osmocom.org/c/osmo-sgsn/+/43390.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1
Gerrit-Change-Number: 42594
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 25 Aug 2026 15:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to