Attention is currently required from: fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: stp: Use SI in valid range when transmitting data
......................................................................
stp: Use SI in valid range when transmitting data
ITU Q.704 14.2.1 defines Service Indicator as being 4 bits, hence valid
range of the field is 0..0x0F. M3UA encodes it inside a full octet
"justified to the least significant bit. Unused bits are coded `0'."
Make sure we send a value inside range, since newer libosmo-sigtran will
validate the received m3ua field.
Use SI=0010 "spare" since we are not really sending any meaningful data.
Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb
---
M stp/STP_Tests_M3UA.ttcn
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/83/43383/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb
Gerrit-Change-Number: 43383
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
